jack1e0 / pe

0 stars 0 forks source link

Filtering finance by time #2

Open jack1e0 opened 11 months ago

jack1e0 commented 11 months ago

When i input: filter-t s/18-11-2023 e/18-11-2023, or filter-t s/tmr e/tmr the finance at time 18-11-2023 15:00 will appear.

but when i input: filter-t s/18-11-2023 15:00 e/18-11-2023 15:00, or filter-t s/tmr e/18-11-2023 15:00 nothing is displayed.

nus-se-script commented 11 months ago

Team's Response

Thank you for your feedback :)

In cases filter-t s/18-11-2023 e/18-11-2023 and filter-t s/tmr e/tmr, the start and end times are automatically set to 18-11-2023 00:00 and 18-11-2023 23:59. This is documented in the Assumptions when using Date-time Combinations section. Therefore, the finance at time 18-11-2023 15:00 falls in between these two times, and will be displayed.

For case filter-t s/18-11-2023 15:00 e/18-11-2023 15:00, since the time is the same as the start and end time, the app does not consider it "within" the time frame.

Whereas case filter-t s/tmr e/18-11-2023 15:00 is essentially from 18-11-2023 00:00 to 18-11-2023 15:00, in which the app can consider 18-11-2023 15:00 to be "within" that time frame.

We understand the confusion and we also notice that the semantics of "within" could be more clearly expressed in the User Guide. We do believe, however, that the existing feature does correspond to the existing documentation, and it would be quite difficult to consider it as a bug per se. We would consider exploring this issue as a matter for a future iteration, so we would say that this is "not in scope" for now. But thank you for raising this up!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]