Open Efreak opened 2 years ago
Thank you very much, this is some really great feedback :) All good suggestions! Here are my initial thoughts, though I will have to think about some of these a bit more..
1) Mostly Agree, I will have to try each (user list, single transfer, chat) and make sure it feels okay.
2) Will do. I did implement this in Chatroom, it was just an oversight that it is not in Private Messages. I will make magnet links (and also eventually slsk:// links) clickable as well. *Note: if you are long clicking a message in a chat room and nothing is showing up then that's a bug so let me know.
3) Chat - See Note. Messages, Browse - totally agree on both, will do.
4) by "text buttons" do you mean added to the overflow menu, or do you mean a button like "settings" or "logout"? I know the login page is very bare, I really have to think about what I want to do with it...
5) I agree it would be convenient, my only opposition to it would that it might be difficult to implement. Reason being, the way contextual mode is typically implemented in Android is that it expects at least one item selected and deselected all items typically brings you out of the mode (see gmail app long press message for example). So I fear that batch select mode with 0 items may look a bit odd.
6) The way I intend the batch options to work is that they get OR'd together, so if you select 1 paused transfer, 1 failed, and 5 completed successfully you will get options Resume, Retry Failed, and Clear Complete with each option only acting on those items that it is applicable for. So the experience you describe seems like a bug. I will let you know if I need help reproducing it.
7) Agree.
8) Agree, only potential concern is menu getting too crowded.
9) Agree.
10) I will add an option to clear incomplete folder of any aborted downloads. The experience you describe seems like a bug, however, since whenever a download is cancelled and removed, it is supposed to clean up after itself.
11) Will have to think about this, as whether one wants to be asked to add a note when adding a user is preference and I could see it going either way. Perhaps a setting checkbox option which says "Prompt to add a note on adding user"?
12) Ah - just checked this out and I think this is a mistake on my part. I see that if a folder has a complete item and a paused item then it does now show the "Clear All Complete" option. I will fix that.
13) Agree, only potential concern is menu getting too crowded.
14) Yeah, a music file is the most common case, but it is quite awkward for other file types. So I think changing it to open is reasonable.
15) This should be straightforward to add and its a good suggestion. I will make it possible to sort alphabetically, date added (default), and perhaps maybe by online status. Unfortunately I never recorded the exact date when users were added, just the order in which they were added.. so that part I will have to think about implementation-wise. 16) Agree. 17) I just looked at this and realized a bug.. so I do support '-' to exclude but the excluded term was '-2014' (i.e. including the '-') rather than '2014'. I will fix this now.
More suggestions
Hi, just as an update maybe half of these are done so far, but I will update you will more details once I get closer to finishing the issue 👍
Here is the current task list. For ones I list as complete and in 2.8.2, feel free to let me know if there is anything missing since even though I listed it under complete I may have missed a case / may still be bugs / may have misunderstood something, but at least to my knowledge they are complete. And also feel free to add any more suggestions / comments.
Complete (in 2.8.2): 2, 3, 6, 7, 8, 11 (its a separate option wherever add user is an option), 12, 14, 15, 17, 19 (less aggressive about logout)
Complete (currently in github / next release): 20, 10
To do soon: 5, 18 - I had held off on these, since I was still debating whether one can be in context mode with 0 selected (which effects both the button and the invert). But I think its fine and will be more convenient. 9 - This should not be too hard, just have not gotten to it.
Part of larger task / future: 4 - This is in progress, I'm redoing the login screens to be more modern / clean, so this will be part of that. 16 - This one is gonna take some time, so it may be a while. But I definitely want to add the ability to sort / filter transfers though. See for example libretorrent which does it well imo. 22 - The ability to only move downloads once the whole folder is complete is more a niche option, so it is not high priority. The use cases you mention sound cool.
Design Concerns: 1 - This is done for user list. Don't know if I like it for transfers or messages yet. 13 - Still concerned about menu getting to crowded. But perhaps I can add it into a "More Options" along with share slsk link and others. 21 - Need to figure out a good design for this.
Not sure if I should open a separate issue for this or not but since it's small I'll just add it here for now: it'd be nice if the app checked for updates everytime it's opened, or at an interval that can be configured, or at least if the version on the GitHub releases would, so users using that wouldn't be left on updates. I know you can also watch the GitHub releases, and then it'll send you an email for new releases, but that's annoying in the sense that if you're not using the app, it'll still bother you, whereas with this idea, you'll only be told when it actually matters.
Seeker is included in fdroid, so if you install the fdroid app and configure it to update repos occasionally, you'll get update notifications. That still leaves you with notifications outside the app, but you'll get them with other app update notifications, and the interval is configurable. If you use SkyDroid, it can also silently background install updates via Shizuku (local adb proxy for nonroot devices, I use it in place of fdroid privileged extension).
On the other hand, GitHub releases API is fairly simple to parse.
Since the version on github releases is exactly the same as fdroid (since that is where IzzyDroid pulls from) I would recommend using fdroid for managing updates. That being said, I can add an opt-in feature "Check for updates on app launch" or similar.
I prefer sticking to the main F-Droid repo for things. That being said, I'm getting this app from the Play Store right now, so I don't suppose the feature would be that useful for me at the moment.
Please bear with me because this is going to be a bit big. Almost all of this is QoL stuff, like sorting, and none of it is actually important. As a tablet user with a 10" screen and add someone who likes information density, my tastes may vary from yours (specifically 4). Most of these requests are just UI changes, I've tried to move those that require significant changes/with at the bottom.
grep -iE 'intent|open|uri|url|link
and reading MessagesActivity.cs and ChatActivity.cs didn't help...about
file that's no longer needed after reading, or maybe I accidentally downloaded the wrong file.These will probably require more work:
tribute creedence
gets me the 2014 blues tribute to Creedence Clearwater Revival, pavement Nicene edition Tribute to the clean, a pickin' on tribute, etc. This should be made far easier with filter support for-2014 -blues -pavement -corners -pickin -covers -blugrass
If you'd prefer that I submit multiple issues, I can do that, I'm just trying not to drown you with notifications.