jackBonadies / SeekerAndroid

Android client for the Soulseek peer-to-peer network
GNU General Public License v3.0
247 stars 4 forks source link

Register the workflow in the default branch instead of the master branch. #23

Closed Efreak closed 2 years ago

Efreak commented 2 years ago

This will allow the process in #22 to be finished, because ANNOYING STUFF

whining about how I can't get the workflow defined in the fdroid branch to keep the logic with the code > This started out quite simple until I tried to take a screenshots and realized that my actions tab shows no actions available. I've tried a whole bunch of stuff and figured out: 1. If I create a `workflow1` in the fdroid branch, it doesn't show up in the actions tab (by name) 2. if I create a `workflow1` in the default branch, it shows up (by name) 3. If I create a `workflow1` with the same name in both branches, it shows up correctly (by name) and allows me to choose which branch I want to run it in. 4. If I create a `workflow1` in the default branch and a `workflow2` in the fdroid branch, the actions tab shows `workflow1` and `.github/workflows/workflow2`. It shows the path for workflow2, rather than the name, though IIRC the workflow worked correctly 5. I can't get automated on:release actions to run from another branch *no matter what I do*. - I think you might need to create your release from the branch you want the action to run on. In other words, if you create the workflow in the fdroid branch, it might *only* run when you release from the fdroid branch. See [Triggering a workflow](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow) (*GitHub searches the .github/workflows directory in your repository for workflow files that are present in the associated commit SHA or Git ref of the event.*) - I didn't bother to test this, because I don't want releases containing an fdroid repository instead of source code 6. I didn't know any of this until now because until now I've never tried using the release trigger, or working with a repository of source code (so far I've only used actions for releases from other repos, and the default branch has been the one with the repo)