search

jackalope / jackalope-doctrine-dbal

Doctrine DBAL transport implementation for Jackalope
http://jackalope.github.io
Other
143 stars 60 forks source link

feat(primary key): add missing primary key for phpcr_type_childs #372

Closed MichelFalke closed 4 years ago

MichelFalke commented 4 years ago

If settings for percona or strict it requires a primary key on each table. To be backwards compatible we added a primary key on a new field, so there won't be breaking changes.

MichelFalke commented 4 years ago

I think it will add functionality for the Percona cluster and will not break any other situation. Thats why my opinion on this matter is that it shouldn't be more complex than this PR. Thanks for the feedback on the upgrade.

alexander-schranz commented 4 years ago

We are also running in digitalocean clusters into this issue. Is it possible to create a release for this. Think it will break nothing as we don't do any queries on the id.

dbu commented 4 years ago

sure: https://github.com/jackalope/jackalope-doctrine-dbal/releases/tag/1.5.0