search

jackalope / jackalope-doctrine-dbal

Doctrine DBAL transport implementation for Jackalope
http://jackalope.github.io
Other
143 stars 60 forks source link

[WIP] Add: phpcr-utils PR test #379

Closed ghost closed 3 years ago

ghost commented 3 years ago

Temporary pull request for test purposes.

See: https://github.com/phpcr/phpcr-utils/pull/194

dbu commented 3 years ago

thanks. this looks pretty good, except for the lowest version build. i am quite confused by that one as we have other tests in phpcr-utils that also extend from the TestCase and those don't fail. i just rebuilt the master branch and it is green too. i will go ahead and merge - worst case we need to dig into what goes wrong with this specific test in the lowest version build.

dbu commented 3 years ago

i merged and tagged the phpcr-utils change. lets see what the lowest version build does now.

dbu commented 3 years ago

not sure what exactly happened, but i re-ran the build on the master branch after tagging 1.5.2 and all builds succeed \o/

thanks again for the fix.