jackalope / jackalope-doctrine-dbal

Doctrine DBAL transport implementation for Jackalope
http://jackalope.github.io
Other
143 stars 60 forks source link

CachedClient: Intepret only FALSE as a cache miss #380

Closed d3vpunk closed 3 years ago

d3vpunk commented 3 years ago

Hi. while exploring the possibility of using query cache in our project, we noticed that empty results were not interpreted as a cache hit. We added a stricter check (!== false) to make this possible.

This point is somewhat related to this issue: https://github.com/doctrine/DoctrinePHPCRBundle/pull/359

dbu commented 3 years ago

released as 1.6.1

d3vpunk commented 3 years ago

thanks @dbu incredibly fast :)