search

jackalope / jackalope-doctrine-dbal

Doctrine DBAL transport implementation for Jackalope
http://jackalope.github.io
Other
143 stars 60 forks source link

Allow Doctrine Cache 2 #408

Closed derrabus closed 1 year ago

derrabus commented 1 year ago

Doctrine Cache is not maintained anymore. Version 2 is a transitional package with PSR-6 wrappers.

This PR allows the installation of v2 and uses Symfony Cache as a cache implementation for tests. The one problem I could not solve easily is this fallback here:

https://github.com/jackalope/jackalope-doctrine-dbal/blob/7a17d5955c52cd3a80b9f6e0b98da360f838917d/src/Jackalope/Transport/DoctrineDBAL/CachedClient.php#L41

I chose to throw an exception if the meta cache has not been configured and ArrayCache is not available.

In the long run, this package should probably transition to PSR-6 and abandon Doctrine Cache completely.

dbu commented 1 year ago

https://github.com/jackalope/jackalope-doctrine-dbal/releases/tag/1.9.0

dbu commented 1 year ago

i created #411 to discuss about caching in jackalope 2.0