search

jackalope / jackalope-doctrine-dbal

Doctrine DBAL transport implementation for Jackalope
http://jackalope.github.io
Other
143 stars 60 forks source link

fix reference deletion to not be case sensitive #435

Closed dbu closed 9 months ago

dbu commented 9 months ago

as found in https://github.com/jackalope/jackalope-doctrine-dbal/pull/434

dbu commented 9 months ago

@alexander-schranz does that make sense? i think it actually is a regression of 1.11.0, we would no longer delete dangling references if the xml uses sv:type with uppercase name.

alexander-schranz commented 9 months ago

Looks fine from my side, didn't have any effects on performance improvements as tested in: https://github.com/alexander-schranz/jackalope-xml-delete-properties

dbu commented 9 months ago

thanks. i think there would be no visible effects of the problem, "just" data not being deleted from a table but not doing any harm.