search

jackaudio / jack1

jack1 codebase
Other
250 stars 71 forks source link

Remove example-clients and tools #109

Closed dvzrv closed 2 years ago

dvzrv commented 2 years ago

As the example-clients and tools are now tracked in https://github.com/jackaudio/jack-example-tools/ and can be built against jack1 and jack2 (see https://github.com/jackaudio/jack-example-tools/pull/8), they should be removed from jack1, so that it will become easier for users to switch between the different implementations of jack in the future, while using the same tooling (ideally).

falkTX commented 2 years ago

This should coincide nicely with a new jack1 release.

If doing a new one, I would push to get jackdbus working too. There is a patch but it needs to be reformatted.

dvzrv commented 2 years ago

It doesn't all have to be in one release :)

dvzrv commented 2 years ago

In #112 we now track the removal of the files in a PR.

IMHO the PR should only be merged after a new release of jack1 has been made, incorporating the changes mentioned in #108 so that jack-example-tools can be built without issue. The changes should then be released in an additional release, to have a clear migration path for downstreams.

falkTX commented 2 years ago

There is no downstream that still uses jack1 afaik, so this is quite safe to go for. Even BSD has now moved to jack2.