search

jackaudio / jack1

jack1 codebase
Other
250 stars 71 forks source link

Autotool fixes #31

Closed erikd closed 8 years ago

erikd commented 8 years ago

And a whitespace fixup.

pauldavisthefirst commented 8 years ago

Thanks. I'll get to this (and some other pull requests) after Ardour 4.5 gets out the door.

erikd commented 8 years ago

Yep, thats fine. Thanks.

erikd commented 8 years ago

Ping?

pauldavisthefirst commented 8 years ago

see recent mail to jack-devel.

it will happen.

On Wed, Feb 10, 2016 at 9:14 PM, Erik de Castro Lopo < notifications@github.com> wrote:

Ping?

— Reply to this email directly or view it on GitHub https://github.com/jackaudio/jack1/pull/31#issuecomment-182673494.

pauldavisthefirst commented 8 years ago

These changes do not work correctly with the version of autotools present in Debian Jessie (at least). It enters an endless loop inside the generated configure script. Just another reason why autotool stuff sucks, since no doubt it works fine for you.

erikd commented 8 years ago

I just tried it on Jessie and can confirm your report of an endless loop. A little preliminary debugging suggests that this is due to incorrect/duplicate usage of AC_INIT (which autoconf was already warning about). I'll figure out the best way to fix that some time today and provide an updated version of this patch.

erikd commented 8 years ago

Tested on Debian Testing/Unstable and Debian Jessie.

erikd commented 8 years ago

I suspect the "Sync tools submodule" commit is incorrect, but unsure of how to submit it the right way.

pauldavisthefirst commented 8 years ago

make maintainer-clean now fails, with this error:

Makefile:621: ../libjack/.deps/libjackserver_la-unlock.Plo: No such file or directory Makefile:622: ../libjack/.deps/libjackserver_la-uuid.Plo: No such file or directory make[1]: *\ No rule to make target '../libjack/.deps/libjackserver_la-uuid.Plo'. Stop. make[1]: Leaving directory '/usr/local/music/src/jack/jackd' Makefile:534: recipe for target 'maintainer-clean-recursive' failed

erikd commented 8 years ago

Thanks. I'll fix that.

erikd commented 8 years ago

Have now tested on Debian Testing and Jessie using:

./autogen.sh && ./configure --prefix=/usr && make clean all clean dist maintainer-clean

No issues found.

This commit does however need to patch for the tools submodule in https://github.com/jackaudio/tools/issues/6 .

erikd commented 8 years ago

Thanks @pauldavisthefirst !