search

jackaudio / jack2

jack2 codebase
GNU General Public License v2.0
2.22k stars 376 forks source link

jackdrc and device names with whitespace #91

Closed x42 closed 9 years ago

x42 commented 9 years ago

on OSX devices can include whitespace. e.g. "AppleUSBAudioEngine:Focusrite:Scarlett 18i6 USB:000039BF:2,1" "AppleUSBAudioEngine:PreSonus:AudioBox 1818 VSL:2209:2,1" etc

The parser in posix/JackPosixServerLaunch.cpp does not handle quotes nor escapes. jack cannot be started by a jackdrc if the device-name contains spaces. NB. The jackdrc parser in JackWinServerLaunch.cpp does handle things correctly.

sletz commented 9 years ago

Patch?

Stéphane

Le 13 janv. 2015 à 19:35, robin notifications@github.com a écrit :

on OSX devices can include whitespace. e.g. "AppleUSBAudioEngine:Focusrite:Scarlett 18i6 USB:000039BF:2,1" "AppleUSBAudioEngine:PreSonus:AudioBox 1818 VSL:2209:2,1" etc

The parser in posix/JackPosixServerLaunch.cpp does not handle quotes nor escapes. jack cannot be started by a jackdrc if the device-name contains spaces. NB. The jackdrc parser in JackWinServerLaunch.cpp does handle things correctly.

— Reply to this email directly or view it on GitHub.

x42 commented 9 years ago

There's no patch, yet. Just filing the issue so that it does not get lost.

I suppose it could be as easy as copy/edit from JackWinServerLaunch to JackPosixServerLaunch. But that may break compatibility with jack1 .jackdrc.

x42 commented 9 years ago

https://github.com/x42/jack2/commit/886a64e02a0f7ce192c318f74cff1f16d5e15bfb

I'll file a pull request