jackbsteinberg / get-originals-rewriter

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Change test file extensions to .mjs #7

Closed domenic closed 5 years ago

jackbsteinberg commented 5 years ago

Looks like jscodemod automatically adds the .input.js and .output.js to the test files in their runTest helper.

What I could do is copy over their testUtils.js file and modify it to support both .js and .mjs

domenic commented 5 years ago

That's annoying. I'm surprised there is no way to configure defaults for the test runner like there is for the command-line argument.

Let's not copy the code for now; instead let's open an issue on jscodeshift, asking them if they'd accept a pull request to configure it, and wait to see what they say.

jackbsteinberg commented 5 years ago

Opened: https://github.com/facebook/jscodeshift/issues/336 to address this

domenic commented 5 years ago

This can be solved as part of #30.