search

jackbsteinberg / std-toast

121 stars 4 forks source link

Replaced emoji with yes/no #32

Closed aardrian closed 5 years ago

aardrian commented 5 years ago

The emoji announce in screen readers as "X, graphic" or "white underscore check underscore mark, graphic" (TalkBack) or "crossmark" or "white heavy checkmark" (NVDA). In Android Chrome, the emoji for the checkmark is white, no green box as you might see on Windows. This will read faster and not have the contrast issue. I would prefer blanks instead of "no", but am not sure if you have a third value for unknown and don't want to mess with that.

Screen shots are from Chrome / Android.

Red X: Screenshot_20190613-145011~2

White check: Screenshot_20190613-143841~2

domenic commented 5 years ago

Thanks so much! I think blanks instead of no makes sense as well, so I'll tweak that and then merge.