jackbsteinberg / std-toast

120 stars 4 forks source link

Transitions and Lifecycle Events #35

Open jackbsteinberg opened 5 years ago

jackbsteinberg commented 5 years ago

An issue I can foresee arising from the usage of transitions in showing and hiding toasts is an event firing before the toast transition has completed, (e.g. dispatching the hide event while the toast is still fading off the screen).

A common pattern to fix this was to separate the events show and hide into the lifecycle events willShow, didShow, willHide and didHide, tied to whether or not the transition has completed. Does this pattern give the desired behavior or is it too specific, and should we instead opt to simply dispatch show and hide when the toast is fully shown/hidden or beginning to show/hide.