I went and looked at the first version of the game to see if I could understand why the logo wouldn't show.
This is the culprit cr.sendWithPromise("get-logo").
This wasn't showing the logo for the same reason it wasn't working with the scores in the new version. "get-logo" is an internal function, not accessible from a webpage running in the browser. It injects the source into this string r.innerHTML = "<button id='edmonds-close'><svg width='16' height='16' xmlns='http://www.w3.org/2000/svg'><line x1='1' y1='15' x2='15' y2='1'></line><line x1='1' y1='1' x2='15' y2='15'></line></svg></button><img id='edmonds-logo' alt='New logo!' src='" + n + "'></img><h1 id='edmonds-title'>Thanks for helping us build the new Microsoft Edge</h1><p id='edmonds-text'>Insiders like you make Edge great. Thanks for being part of our community and surfing the web with us!</p><button id='edmonds-cta'>Close</button>".
🤷♂️ Not something which could have been solved at least like this. I don't have a version of that browser around anymore, but if you do, it looks like it is writing the URL to the console, and you could go back and replace the internal call with just generating the result... Might have been nice to have resolved had I seen the request 8 months ago. Not going to be able to solve it now and I don't see tremendous value in doing so.
I recommend deleting that section from the README as it is no longer relevant.
I went and looked at the first version of the game to see if I could understand why the logo wouldn't show.
This is the culprit
cr.sendWithPromise("get-logo").This wasn't showing the logo for the same reason it wasn't working with the scores in the new version. "get-logo" is an internal function, not accessible from a webpage running in the browser. It injects the source into this string
r.innerHTML = "<button id='edmonds-close'><svg width='16' height='16' xmlns='http://www.w3.org/2000/svg'><line x1='1' y1='15' x2='15' y2='1'></line><line x1='1' y1='1' x2='15' y2='15'></line></svg></button><img id='edmonds-logo' alt='New logo!' src='" + n + "'></img><h1 id='edmonds-title'>Thanks for helping us build the new Microsoft Edge</h1><p id='edmonds-text'>Insiders like you make Edge great. Thanks for being part of our community and surfing the web with us!</p><button id='edmonds-cta'>Close</button>".🤷♂️ Not something which could have been solved at least like this. I don't have a version of that browser around anymore, but if you do, it looks like it is writing the URL to the console, and you could go back and replace the internal call with just generating the result... Might have been nice to have resolved had I seen the request 8 months ago. Not going to be able to solve it now and I don't see tremendous value in doing so.
I recommend deleting that section from the README as it is no longer relevant.