Update edid-decode.c

[sqnoc]

These changes make the serial number information in the inventory.

[jackburton79]

Hi. This change breaks the build here. cc -c -o edid-decode.o edid-decode.c edid-decode.c: In function ‘detailed_block’: edid-decode.c:487:62: error: expected ‘;’ before ‘)’ token extract_string(x + 5, &has_valid_string_termination, 13)); ^ edid-decode.c:487:62: error: expected statement before ‘)’ token edid-decode.c: In function ‘get_edid_info’: edid-decode.c:1412:48: error: expected ‘;’ before ‘)’ token

• (edid[0x0E] << 16) + (edid[0x0F] << 24)); ^ edid-decode.c:1412:48: error: expected statement before ‘)’ token edid-decode.c:1736:5: warning: passing argument 1 of ‘strncpy’ makes pointer from integer without a cast [enabled by default] strncpy(info->serial_number, tmp, sizeof(info->serial_number)); ^ In file included from edid-decode.c:30:0: /usr/include/string.h:128:14: note: expected ‘char * restrict’ but argument is of type ‘int’ extern char strncpy (char restrict dest, ^ make: * [edid-decode.o] Errore 1

[sqnoc]

I change type of variable "serial_number" in edid-decode.h intserial_number; => char serial_number[32];

Le 25/08/2014 21:10, Stefano Ceccherini a écrit :

Hi. This change breaks the build here. cc -c -o edid-decode.o edid-decode.c edid-decode.c: In function ‘detailed_block’: edid-decode.c:487:62: error: expected ‘;’ before ‘)’ token extract_string(x + 5, &has_valid_string_termination, 13)); ^ edid-decode.c:487:62: error: expected statement before ‘)’ token edid-decode.c: In function ‘get_edid_info’: edid-decode.c:1412:48: error: expected ‘;’ before ‘)’ token

• (edid[0x0E] << 16) + (edid[0x0F] << 24)); ^ edid-decode.c:1412:48: error: expected statement before ‘)’ token edid-decode.c:1736:5: warning: passing argument 1 of ‘strncpy’ makes pointer from integer without a cast [enabled by default] strncpy(info->serial_number, tmp, sizeof(info->serial_number)); ^ In file included from edid-decode.c:30:0: /usr/include/string.h:128:14: note: expected ‘char * restrict’ but argument is of type ‘int’ extern char /strncpy (char /restrict dest, ^ make: *// [edid-decode.o] Errore 1

— Reply to this email directly or view it on GitHub https://github.com/jackburton79/agent/pull/1#issuecomment-53312870.