jackc / edge

Edge provides graph functionality to ActiveRecord.
MIT License
90 stars 10 forks source link

Fixed premature SQL-ization that could result in PG protocol violation errors #15

Closed hx closed 9 years ago

hx commented 9 years ago

Resolves issue https://github.com/jackc/edge/issues/14.

Calling to_sql and then adding subsequent scopes can result in SQL containing WHERE FOO = $1 AND BAR = $1, where the second $1 should be $2.

See https://github.com/rails/rails/issues/20236 for a complete explanation.

jackc commented 9 years ago

Thanks!

hx commented 9 years ago

Very welcome. We enjoy making good use of your work. Looking forward to seeing a new revision on rubygems.org :+1:

jackc commented 9 years ago

https://rubygems.org/gems/edge/versions/0.4.2