Fix json marshal/unmarshal implementations for SCRAM messages

jackc / pgproto3

MIT License

161 stars 43 forks source link

Closed gitstashpop closed 3 years ago

gitstashpop commented 3 years ago

Also add json marshaling for AuthenticationOK.

gitstashpop commented 3 years ago

@henvic @jackc ptal

henvic commented 3 years ago

Hi @yulicrunchy,

I've noticed that a JSON Marshaler is also missing for the following structs:

AuthenticationCleartextPassword
AuthenticationMD5Password
ErrorResponse
NoticeResponse (which is a type ErrorResponse, so solving for ErrorResponse is enough)

gitstashpop commented 3 years ago

I added the missing implementations as requested.

jackc commented 3 years ago

LGTM

henvic commented 3 years ago

Hey @jackc, could you please tag a new version? Thank you!