search

jackc / pgtype

MIT License
314 stars 112 forks source link

implement nullable values for hstore maps #131

Closed boindil closed 3 years ago

boindil commented 3 years ago

I added the implementation for hstore maps with nullable values.

Closes #127

jackc commented 3 years ago

Overall looks good.

Only thing that jumped out at me was the added cases for *string and *[]byte to Scan(). I'm pretty sure that those are not types that database/sql uses. So I don't see how they would ever be used (or what they have to do with the this feature).

boindil commented 3 years ago

Hi @jackc, I'm not too familiar with database/sql and it seems I've made the wrong assumption for this here. I thought that it would've need to be extended for the pointer-types to be properly supported.

Anyways, I've reverted that :)