search

jackc / pgx

PostgreSQL driver and toolkit for Go
MIT License
10.86k stars 846 forks source link

V1 XMLCodec supports encoding + scanning XML column type #2083

Closed nickcruess-soda closed 4 months ago

nickcruess-soda commented 4 months ago

We have a need for the XML column type but observed that it isn't currently supported. I've taken the JSONCodec as a starting point and adapted it for XML. They turned out to be quite similar. I left in some of the issue-referencing comments from the JSONCodec which seemed relevant here as well, such as the one explaining the driver.Valuer vs xml.Marshaler ordering in PlanEncode.

While I was at it I also noticed some unused code related to the JSONCodec (scanPlanJSONToBytesScanner), which I removed in the second commit. Happy to drop that if this isn't the place/time for it.

jackc commented 4 months ago

It looks like the tests will need to skip CockroachDB.