search

jackc / tod

Time of day and shift types for Ruby
MIT License
435 stars 56 forks source link

Add ability to use AR’s attribute API #59

Closed BrentWheeldon closed 6 years ago

BrentWheeldon commented 6 years ago

The attribute API allows us to specify custom types for fields and because of where it fits into the lifecycle we don't need to modify the time_zone_aware_types configuration.

Given there's not a tonne of logic here I didn't add any specs, but I'd be happy to add some in if you'd like.

jackc commented 6 years ago

Thanks!

BrentWheeldon commented 6 years ago

Thanks for merging. Would it be possible to get a new version of the gem cut?

jackc commented 6 years ago

Sure. Just release 2.2.0.

BrentWheeldon commented 6 years ago

Thanks again!