Confusion over has_one and foreign keys in Job

[joshmcarthur]

@jarsbe,

I was going to fix this myself, but I think it's probably part of a wider issue you should take a look at.

If you take a look at db/schema.rb#jobs alongside the Job model, you'll see that the associations are a little funky - there are some ID columns that are there that shouldn't be, some associations that have the wrong type, and some associations that should have an ID column that don't.

• has_one :categorisation means you don't need category_id
• has_one :classification means you don't need type_id
• Region & City - is it possible for an Employer to select an Region AND a City that this job applies to, or just one city, or multiple cities in a region, or multiple cities across regions? Whichever way, I don't think you need a belongs_to relationship to City AND Region - perhaps Job belongs_to City, Job has_one Region through City?

Have a look anyway, and I'm happy to talk about it tomorrow.

[joshmcarthur]

@jarsbe this is blocking me right now due to the DB constraints on keys that expect to be there but aren't. It's no big deal, I'll just take a look at searching instead.

[jackcallister]

@joshmcarthur, you're completely right with removing category_id and type_id. Happy to discuss anything tomorrow if you're uncomfortable clearing it up. As for Addresify (feel free to rename that!) the relevant model must have a region but not necessarily a city.

[joshmcarthur]

Closed by f966f60af5fa1d5a567ec1e39abc4ecd6dfc3b49