jackd248 / temps

Simple menubar application based on Electron with actual weather information and forecast.
https://jackd248.github.io/temps/
MIT License
557 stars 72 forks source link

Tray icons #28

Open bilelmoussaoui opened 7 years ago

bilelmoussaoui commented 7 years ago

Hello, In Linux users love the possibility to change the all the icons by changing the main icon theme. it seems that Electron does not support that at the moment; so I've created a small script that handles that.

In order to implement your application support https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/253. I'm wondering if the tray icons are the same as the ones used on the application. Or the tray uses the png ones? and the application uses the SVG ones.

Thanks!

jackd248 commented 7 years ago

I will check and test this in the next version. They are all the same icons, doesn't matter if the svg or the png ones. For now you only have the possibility to change the tray icon manually inside the settings menu.

bilelmoussaoui commented 7 years ago

@jackd248 Thanks! I know about the settings, the purpose of my script is to provide the possibility to let the user apply his current theme to the hardcoded tray icons (that does not use the user theme). It's an upstream issue on Electron, but it's hacky solution for now. Anyway, having a specific folder for tray icons or just tray_icon_name.{svg/png} would be more than enough! In order to avoid breaking the application UI for the user. Thanks again!

bilelmoussaoui commented 7 years ago

And btw, i've created an AUR package for Archlinux users. The package can be installed using yaourt -S temps and here's the package https://aur.archlinux.org/packages/temps/. And the packaging information are here https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=temps. If you need me to modify anything just let me know ;) i will try to keep this up to date!