search

jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 176 forks source link

Rails3 compatibility #11

Closed arkan closed 13 years ago

arkan commented 13 years ago

Hi, I just did little changes to remove some deprecated warnings. So, you can apply these changes if you want.

Regards

jackdempsey commented 13 years ago

hey Arkan,

What warnings does this remove? Is it still usable as a plugin without the init there? Happy to apply if so, just want a little more info first.

thx, jack

arkan commented 13 years ago

Sorry, I didn't see this message ...

It removes warnings saying that these files should be move to new locations.

It is a necessary action, to be in full compliance with rails 3

I didn't try to use it as plugin, but I can try if you want.

Regards

jackdempsey commented 13 years ago

Hey Arkan,

No worries, appreciate the response! I would indeed like to be sure it's still correct and works as expected when used as a plugin.

Thanks, Jack

jackdempsey commented 13 years ago

Closing as this has gone stale. If confirmation of it working as a plugin can be had, will merge in.