search

jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 176 forks source link

Another deprecation warning #14

Closed alexz77 closed 13 years ago

alexz77 commented 13 years ago

This is another deprecation warning for rails 2.3.8, also previous commit was missing deletion of tasks folder.

jackdempsey commented 13 years ago

Hi Alexey,

Thanks for the changes. Was this using the v2.0.1 tag with rails 2.3.8 or master?

alexz77 commented 13 years ago

I'm not sure, how tags work. I made changes in branch 2.x, when I select tag v.2.0.1, changes are not there. Also, root/tasks is still there for master branch, meaning there should also be a deprecation warning. Also, under that tasks folder is the only task that is commented out, maybe worths just removing it?

jackdempsey commented 13 years ago

Ahh, I see, you are on the 2.x branch, great.

I've merged in the updates and pushed your fix to the 2.x branch, as well a new 2.1.0 gem to rubygems.org. Thanks!