search

jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 176 forks source link

Added some tests #20

Closed mickey closed 13 years ago

mickey commented 13 years ago

Hey jack, I added some tests since I need to add some features in the near-future, I thought it could help the master :-)

Hope it helps,

Mike

jackdempsey commented 13 years ago

hey Mickey,

Thanks! Will definitely pull these in later. Appreciate it.

jack

jackdempsey commented 13 years ago

Hey Mickey,

Pulled, merged, and pushed. Thanks!

j

mickey commented 13 years ago

Hi Jack, Thanks for the merge !

My first commit was only some tests but the ones who follows were some new features (not sure you noticed). So I updated the README with the new changes : https://github.com/citizencast/acts_as_commentable/commit/f1c780f63032c8bb8146545dbf34cde9f8c5d2a4

Let me know what you think of this changes. I'll make a pull request if you want to include this changes otherwise you should rollback to my first commit (with only tests for the current plugin)

jackdempsey commented 13 years ago

hey Mickey,

Thanks for pointing that out, I somehow did not notice. Please do create a pull request so I can easily remember to track it and see what I think about merging it. Idea sure sounds good.

thx, j