search

jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 178 forks source link

multiple comments for a model not available on 3.0.1 version #29

Closed netbe closed 11 years ago

netbe commented 11 years ago

I have added a comment on the readme. I have seen the issue https://github.com/jackdempsey/acts_as_commentable/issues/23 and I don't understand why the 4 version does not work on Rails 3.

I am using it right now on Rails 3.2, I don't see the issue

jackdempsey commented 11 years ago

I don't understand. You added a comment saying "it's only available on 4.0 and above, but your comment here says you're using it on rails 3.2 and don't see the issue. Can you please clarify? Thx!

netbe commented 11 years ago

I see that's ambiguous, I meant 4.0 for the version of the gem not Rails

jackdempsey commented 11 years ago

your comment is unclear tho: you say it seems to work on 3.2 but then you provide some text saying it's for 4. Do you see where i'm a little confused? If you can clear that up for me i'm happy to merge this

On Fri, Nov 16, 2012 at 9:04 AM, François Benaiteau < notifications@github.com> wrote:

I see that's ambiguous, I meant 4.0 for the version of the gem not Rails

— Reply to this email directly or view it on GitHubhttps://github.com/jackdempsey/acts_as_commentable/pull/29#issuecomment-10453939.

netbe commented 11 years ago

Alright, sorry I'll start from the beginning. I used the gem as the README stated before, and installed on my Rails 3.2 project the gem like this:

gem 'acts_as_commentable', '3.0.1'

Then I needed multiple roles. So I was happy to see that has the README stated, I could use :

acts_as_commentable :public, :private

That did not work, because the feature is only available on the version(tag) 4.0 or top of master branch. Reading the README, I understood that the version 4.0 of act_as_commentable was compatible only with Rails 4.0.

So my question finally is: Is the gem (master branch aka tag 4) incompatible with Rails 3.2?

I hope it's clearer now :)

jackdempsey commented 11 years ago

Great, that makes more sense. The 4.0 gem is likely compatiable with rails 3.2, but is not guaranteed to. At a certain point in development it makes sense to 'cut ties' so to speak. With many gems that shadow versions of rails, the versions might be the same (like AAC 4.0 and rails 4), but that doesn't always mean 4.0 won't work with 3.2.

thx for the clarification. i'll merge that in now!

On Fri, Nov 16, 2012 at 9:47 AM, François Benaiteau < notifications@github.com> wrote:

Alright, sorry I'll start from the beginning. I used the gem as the README stated before, and installed on my Rails 3.2 project the gem like this:

gem 'acts_as_commentable', '3.0.1'

Then I needed multiple roles. So I was happy to see that has the README stated, I could use :

acts_as_commentable :public, :private

That did not work, because the feature is only available on the version(tag) 4.0 or top of master branch. Reading the README, I understood that the version 4.0 of act_as_commentable was compatible only with Rails 4.0.

So my question finally is: Is the gem (master branch aka tag 4) incompatible with Rails 3.2?

I hope it's clearer now :)

— Reply to this email directly or view it on GitHubhttps://github.com/jackdempsey/acts_as_commentable/pull/29#issuecomment-10455408.