search

jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 178 forks source link

Add index to commentable & user references. #44

Closed JuanitoFatas closed 10 years ago

jackdempsey commented 10 years ago

hey @JuanitoFatas, thanks for the request!

Can you please update it to remove the line change that exists for the blank space? Also, please confirm what versions of rails and activerecord this syntax works for. Just want to make sure there's no update to the rails dependency needed for this change.

JuanitoFatas commented 10 years ago

This syntax only works in Rails 4. For compatible reason I think we leave the user to add index themselves. Sorry for the disturbance.

jackdempsey commented 10 years ago

No disturbance at all!

On Fri, Jan 17, 2014 at 4:33 AM, Juanito Fatas notifications@github.comwrote:

This syntax only works in Rails 4. For compatible reason I think we leave the user to add index themselves. Sorry for the disturbance.

— Reply to this email directly or view it on GitHubhttps://github.com/jackdempsey/acts_as_commentable/pull/44#issuecomment-32602117 .