jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 178 forks source link

Adds role based inflection method for rails5 #66

Open ingedmundo opened 8 years ago

ingedmundo commented 8 years ago

Basically just added

        def define_role_based_inflection_5(role)
          has_many "#{role.to_s}_comments".to_sym,
                   -> { where(role: role.to_s) },
                   has_many_options(role)
        end

For rails5 compatibility

jasdeepsingh commented 7 years ago

👍 we need this in order to upgrade our app to Rails 5. For now I'm using @ingedmundo 's fork. Would appreciate if this could be merged into the official gem.

sumitngupta commented 7 years ago

+1 on using @ingedmundo's fork till this is merged in. Been working great for us in practice. Would love to get back onto the main line gem.

<3

sumitngupta commented 7 years ago

Is this library still maintained?

xxx commented 6 years ago

Is this ever going to get merged? We're approaching 2 years now.