jackdempsey / acts_as_commentable

The ActiveRecord acts_as_commentable plugin
http://juixe.com/svn/acts_as_commentable/
MIT License
834 stars 178 forks source link

Fix Ruby 2.7 keyword parameters deprecation warning #76

Open r7kamura opened 4 years ago

r7kamura commented 4 years ago

This fixes the following warnings that are printed when using this gem with Ruby 2.7.:

/home/ubuntu/foo/vendor/bundle/ruby/2.7.0/gems/acts_as_commentable-4.0.2/lib/commentable_methods.rb:58: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/ubuntu/foo/vendor/bundle/ruby/2.7.0/gems/activerecord-6.0.3.1/lib/active_record/associations.rb:1370: warning: The called method `has_many' is defined here
CloCkWeRX commented 3 years ago

@jackdempsey - would you be ok granting other contributors merge rights; or release rights for this gem? I know for example, fat_free_crm makes use of this and would be happy to take over the maintenance or do an updated/renamed fork.