search

jackdempsey / sequel_polymorphic

MIT License
37 stars 13 forks source link

Merge options passed into all methods #19

Closed shioyama closed 7 years ago

shioyama commented 7 years ago

Continued from #16, based on suggestion from @kuruga.

shioyama commented 7 years ago

@jackdempsey What do you think about this change? I agree with @kuraga that this makes more sense.

Also, it would be great if a new version could be released so projects that depend on this feature can check that it is available.

jackdempsey commented 7 years ago

I think that looks fine, just gotta be careful about keys showing up that will conflict with calls unexpectedly.

I don't use this code these days but [edit] I gave you access now and @kuraga also has access so I hope that helps. I can also add you to the rubygems account if desired.

kuraga commented 7 years ago

@shioyama I'll make a release soon.

shioyama commented 7 years ago

@kuraga Thanks!

kuraga commented 7 years ago

@jackdempsey push new version to RubyGems, please