Add option for users to generate minified stylesheets using the build:minify command

jackdomleo7 / Checka11y.css

A CSS stylesheet to quickly highlight a11y concerns.

https://checka11y.jackdomleo.dev

MIT License

446 stars 31 forks source link

Add option for users to generate minified stylesheets using the build:minify command #146

Closed tannerdolby closed 3 years ago

tannerdolby commented 3 years ago

Description

Fixes #144

Why is this important?

This will allow users to generate minified stylesheets with npm run build:minify, it currently generates the minified files at the root directory as <original_filename>-minified.css. If a user wanted to only generate one of the stylesheets or two, we could add that logic.

Covered test cases

No test cases have been added yet.

Did you test on all major browsers?

[x] Chrome
[x] Firefox
[ ] Edge
[ ] Safari

T&Cs

[x] I confirm I have read and understand the contributing guidelines
[x] I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
[x] I confirm the work in this pull request is true and valid to the best of my knowledge
[x] I have updated the README, features.md and codes.md files where applicable

tannerdolby commented 3 years ago

This PR cleans up my mistakes in #145 of committing the package-lock.json which created a very large 6k diff.

tannerdolby commented 3 years ago

You're welcome @jackdomleo7! I'm glad you mentioned using the clean-css-cli package because it much better suits our needs here. We can now minify stylesheets straight from the command line using build:minify and without any JS added to the project 🙂

tannerdolby commented 3 years ago

Ok great! You're welcome. Ah, gotcha I will resolve that merge conflict real quick.

jackdomleo7 commented 3 years ago

Sorry @tannerdolby... I added some commits that I forgot when reviewing, then the tests wouldn't run. Even though I didn't touch the tests. Then I had to add a few more commits, including adding clean-css as a dev dependency because it wasn't liking it for some reason. Strange how it passed for you though. 🤔

Anyway, thank you for this!

tannerdolby commented 3 years ago

No worries @jackdomleo7! You're welcome :)

Thanks for adding the commits needed to push this through. Yeah I didn't think clean-css-cli needed clean-css at all since the cleancss command in package.json is directly coming from clean-css-cli. But maybe like you mentioned, clean-css-cli needs clean-css as a peer dependency. Either way, I'm glad to see the project now gives users the option to use minified stylesheets.

Thank you for reviewing and seeing this through! 🙂