jackdomleo7 / Checka11y.css

A CSS stylesheet to quickly highlight a11y concerns.
https://checka11y.jackdomleo.dev
MIT License
446 stars 31 forks source link

Update Cypress from version 6 to the latest version 8.7.0 #147

Closed tannerdolby closed 3 years ago

tannerdolby commented 3 years ago

Description

Fixes #113

In Cypress 8:

Why is this important?

This is important in order to utilize the newest features in v8.

The Pipeline / tests are failing and suggests I include the package-lock.json file (after running a fresh npm install), this will be a pretty large diff but I'm happy to do it if need be.

Covered test cases

No tests were added or modified.

Did you test on all major browsers?

T&Cs

jackdomleo7 commented 3 years ago

Thanks @tannerdolby, yeah it'd be really good to include the package-lock.json (you'll just need to ensure you are using npm@7 or npm@8 so the file is generated using lockfile v2).

What really interests me about this PR is that you've literally only updated the dependency version and edited the script. Here's me thinking this was gonna need some major refactoring 😅

tannerdolby commented 3 years ago

You're welcome @jackdomleo7, ahh yes that was the issue. I hadn't updated npm in awhile so I will do that and then generate the lock file with npm install (ensuring its npm@7 or higher) and commit it.

Yeah, it was interesting that there wasn't really anything other than the --headless flag that was needing to be changed. I went through the migration guide provided by Cypress (checking v7 and v8 migrations) and checked the project, these couple of changes were all I could find. Maybe a deeper dive into the 8.7.0 changelog would reveal more things potentially needing to be changed but I think this oddly enough completed the migration from 6 to 8 😅

jackdomleo7 commented 3 years ago

@tannerdolby I'm happy to merge this PR, but there seems to be an issue with your commits not being signed 🤔 image