search

jackdpage / python-gdtf

Python library for General Device Type Format
MIT License
4 stars 2 forks source link

"Cylinder" PrimitiveType not working #2

Closed hugoaboud closed 2 years ago

hugoaboud commented 3 years ago

Every Model with a "Cylinder" PrimitiveType defined on the xml is loaded as "Undefined" PrimitiveType.

The problem is actually just a missing comma, right before 'Cylinder', in value.py:49:

class PrimitiveType(Enum):
    permitted = ['Undefined', 'Cube' 'Cylinder', 'Sphere', 'Base', 'Yoke',
                 'Head', 'Scanner', 'Conventional', 'Pigtail']

Since this is a really simple problem I decided not to do a pull request. Thanks again for your work on this lib.