search

jackfagner / OpenTidl

Free and open source API for TIDAL
GNU Affero General Public License v3.0
44 stars 18 forks source link

Publish to NuGet #2

Closed HenningKlokkeraasen closed 8 years ago

HenningKlokkeraasen commented 8 years ago

Hi, sorry for creating an issue - it's the only way to contact a user. First - thank you very much for open sourcing this library. I am using it in a couple of projects now. It is really great! Would you consider publishing it to NuGet.org, or another NuGet host (e.g. MyGet?) It would make it easier to create projects that depend on OpenTidl. If not - would you mind if I publish my forked version?

jackfagner commented 8 years ago

Good idea. I'll publish "official" OpenTidl to GitHub soon. You may of course publish your fork as well, but to avoid confusion I would recommend you to change the name and preferably also provide a somewhat different feature set (i.e. add some enhancements to differentiate the projects).

HenningKlokkeraasen commented 8 years ago

Great! Btw - you might want to parameterize the API token - otherwise the one hardcoded in ClientConfiguration might be heavily used and perhaps blocked by Tidal due to too much traffic. Not sure they have such a restriction but I guess it could happen. Which would probably mean turning ClientConfiguration.Default into a method with the token as a parameter? Drawback would be that it's less easy to get going, and a breaking change.

jackfagner commented 8 years ago

If I recall correctly, the token is a constant that only changes with a new client release (Android). I.e. Android client v1.10.2 always use token "kgsOOm..". The ClientUniqueKey, on the other hand, should be unique per client (go figure).

HenningKlokkeraasen commented 8 years ago

Aha, I see. Good to know, thanks!