Adding missing functions

jackfirth / pyramda

Python package supporting heavy functional programming through currying. Translation of the Ramda library from javascript to python.

MIT License

127 stars 10 forks source link

Adding missing functions #31

Closed Rafi993 closed 6 years ago

Rafi993 commented 6 years ago

List of functions added times, adjust, uniq, zip_with, zip_obj, xprod, without, update, identity, drop_last, empty, join

jackfirth commented 6 years ago

Hello @Rafi993, nice to meet you! Thanks for taking interest in Pyramda and writing this pull request.

Fair warning: I don't have bandwidth to work on Pyramda at the moment and that's unlikely to change anytime soon. If you're interested in contributing more I'm happy to help with that, but I won't be working on features myself or devoting a lot of time to maintenance tasks. As for the PR, I have a few comments:

The Travis CI failure seems to be from code style warnings, please fix those.
Unit tests are missing. Existing code files in pyramda each have a corresponding _test.py file, and tests are written in plain functions instead of in classes and methods.
I'd like the README to be updated with type signatures of the new functions.

coveralls commented 6 years ago

Coverage increased (+0.3%) to 95.511% when pulling af16c2af45834f433710c441638c4af908dc44d3 on Rafi993:master into 85ab1c2f456085c9e31e3831459ee1a850ab559c on jackfirth:master.

Rafi993 commented 6 years ago

Since this repo seems to be unmaintained I am closing this pull request and host the future changes in the fork. Thanks for the awesome idea you have built

jackfirth commented 6 years ago

I'm happy to work with you to merge these changes @Rafi993. Are you intending to push more commits to this PR?

Rafi993 commented 6 years ago

Yes @jackfirth I do intend to push more commits to the repo so that most of the missing function is covered and I was looking into ways to make currying faster something like this http://code.activestate.com/recipes/229472-high-performance-currying-with-instancemethod/ . and to add benchmarks for each functions. And then to clean up the Readme.md and to have these docs searchable in a separate gitpage.

Rafi993 commented 6 years ago

@jackfirth I'll reopen the pull request and fix errors in my last commit