jackfirth / racket-mock

Mocking library for Racket
Other
22 stars 7 forks source link

Support left and right (curried) positional arguments #136

Closed countvajhula closed 4 years ago

countvajhula commented 4 years ago

This is a WIP PR to implement a possible way of addressing #134 , and needs input on whether it makes sense, is appropriate for inclusion in the arguments package, is a good solution, etc.

The essential change is to decompose positional arguments into two sets left and right, to be able to represent argument sets in curried functions.

codecov[bot] commented 4 years ago

Codecov Report

Merging #136 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          846       846           
=========================================
  Hits           846       846           
Impacted Files Coverage Δ
arguments/main.rkt 100.00% <100.00%> (ø)
mock/private/base.rkt 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a27bb7...38ee4c9. Read the comment docs.

countvajhula commented 4 years ago

With the changes in this PR, the downstream module referenced in #134 would look like this: https://github.com/countvajhula/relation/commit/e1917f75308843bed81df09c0fa08f59eb96caa6

countvajhula commented 4 years ago

See discussion in #134