jackfirth / resyntax

A Racket refactoring engine
Apache License 2.0
51 stars 10 forks source link

uri-old usage #225

Closed sorawee closed 2 days ago

sorawee commented 8 months ago

If I understand correctly, Resyntax uses only one function from uri-old: uri-escape-i. Would it be possible to implement this function directly, and cut the dependency?

Three reasons:

WARNING: collected information for key multiple times: '(dep ((lib "uri-old/main.rkt") uri-with-fragment)); values: #t #t
WARNING: collected information for key multiple times: '(def ((lib "uri-old/main.rkt") uri-with-fragment)); values: '#(#f (def ((lib "uri-old/main.rkt") uri-with-fragment)) #f (doc #"uri-old" #"index.html") #f) '#(#f (def ((lib "uri-old/main.rkt") uri-with-fragment)) #f (doc #"uri-old" #"index.html") #f)
WARNING: collected information for key multiple times: '(index-entry (def ((lib "uri-old/main.rkt") uri-with-fragment))); values: (list '("uri-with-fragment") (list (cached-element (style "RktSym" (list 'tt-chars (css-addition '(collects #"scribble" #"racket.css")) (tex-addition '(collects #"scribble" #"racket.tex")))) "uri-with-fragment" ...)) (delayed-index-desc #<procedure:...a... (list '("uri-with-fragment") (list (cached-element (style "RktSym" (list 'tt-chars (css-addition '(collects #"scribble" #"racket.css")) (tex-addition '(collects #"scribble" #"racket.tex")))) "uri-with-fragment" ...)) (delayed-index-desc #<procedure:...a...
WARNING: collected information for key multiple times: '(dep ((lib "uri-old/main.rkt") uri-with-fragment/escaped)); values: #t #t
WARNING: collected information for key multiple times: '(def ((lib "uri-old/main.rkt") uri-with-fragment/escaped)); values: '#(#f (def ((lib "uri-old/main.rkt") uri-with-fragment/escaped)) #f (doc #"uri-old" #"index.html") #f) '#(#f (def ((lib "uri-old/main.rkt") uri-with-fragment/escaped)) #f (doc #"uri-old" #"index.html") #f)
WARNING: collected information for key multiple times: '(index-entry (def ((lib "uri-old/main.rkt") uri-with-fragment/escaped))); values: (list '("uri-with-fragment/escaped") (list (cached-element (style "RktSym" (list 'tt-chars (css-addition '(collects #"scribble" #"racket.css")) (tex-addition '(collects #"scribble" #"racket.tex")))) "uri-with-fragment/escaped" ...)) (delayed-index-desc ... (list '("uri-with-fragment/escaped") (list (cached-element (style "RktSym" (list 'tt-chars (css-addition '(collects #"scribble" #"racket.css")) (tex-addition '(collects #"scribble" #"racket.tex")))) "uri-with-fragment/escaped" ...)) (delayed-index-desc ...

(Of course, we could also fix mcfly to generate documentation properly without warnings, but this seems difficult)