search

jackfirth / resyntax

A Racket refactoring engine
Apache License 2.0
48 stars 10 forks source link

No refactoring on #lang racket #229

Open sorawee opened 6 months ago

sorawee commented 6 months ago

Why doesn't 

#lang racket

(define (test)
  (let ([x 1])
    (+ x 1)))

get refactored, while 

#lang racket/base

(define (test)
  (let ([x 1])
    (+ x 1)))

does? I agree that there are refactoring that could be unsafe in #lang racket (which is safe in #lang racket/base), but this particular case seems always fine?

jackfirth commented 6 months ago

Just haven't gotten around to it. I was planning to add this when I figured out how to support only applying refactoring rules when their suggestions don't require inserting new imports into the module, but Alex figured that out for me as a byproduct of #166. So I think we can do this now.