search

jackfirth / resyntax

A Racket refactoring engine
Apache License 2.0
51 stars 10 forks source link

The analyze mode should not care about comments #232

Open sorawee opened 8 months ago

sorawee commented 8 months ago

Users of the analyze mode are already applying the changes manually, so it's fine to strip comments away. This is especially good if doing so allows Resyntax to discover more issues.

jackfirth commented 7 months ago

Interesting. All things being equal, I'd rather make Resyntax better at preserving comments automatically than give an option to show fixes that strip them, but I could see this being useful. Though it would also be handy to know which fixes in that linked pull request are fixes that Resyntax wasn't able to preserve comments for - it's possible I could fix that problem directly for some cases.