jackfranklin / gulp-load-plugins

Automatically load in gulp plugins
https://github.com/jackfranklin/gulp-load-plugins
MIT License
757 stars 55 forks source link

Update dependencies to match gulp 4 #108

Closed doowb closed 8 years ago

doowb commented 8 years ago

This PR is to update dependencies to match some that are used in gulp 4.

Since this is an attempt at consolidating common dependencies, I removed the green coloring around the logging messages. If you'd like to keep that, I can add something for it.

callumacrae commented 8 years ago

Maybe worth using gulplog?

Nice work, though :)

jackfranklin commented 8 years ago

Agree with @callumacrae that I'd use gulplog but once that's done awesome work, thank you!

Can you add yourself as a contributor in the package.json too please? :)

tunnckoCore commented 8 years ago

I think it worth using https://github.com/tunnckoCore/load-deps under the hoods, it's pretty fast. Or just take a look and say some feedback :)

Cheers, Charlike!

jackfranklin commented 8 years ago

@tunnckoCore can you open a new issue? It's not related to this PR.

doowb commented 8 years ago

I updated to use gulplog but there are a few caveats:

For the first bullet, we could listen for the events and write to the console but this will result in duplicate logging when users are using gulp-cli.

Also, added my name to the contributors list, thanks!

doowb commented 8 years ago

@jackfranklin I reverted the DEBUG changes per your inline comments.

jackfranklin commented 8 years ago

Thank you! @callumacrae does this look good to you? :)

callumacrae commented 8 years ago

Yep, looks good!

doowb commented 8 years ago

@jackfranklin thanks for merging. Will you publish to npm?

jackfranklin commented 8 years ago

@doowb released as 1.2.3. Thanks :)