Closed doowb closed 8 years ago
Maybe worth using gulplog?
Nice work, though :)
Agree with @callumacrae that I'd use gulplog
but once that's done awesome work, thank you!
Can you add yourself as a contributor in the package.json
too please? :)
I think it worth using https://github.com/tunnckoCore/load-deps under the hoods, it's pretty fast. Or just take a look and say some feedback :)
Cheers, Charlike!
@tunnckoCore can you open a new issue? It's not related to this PR.
I updated to use gulplog
but there are a few caveats:
gulp-cli
which has the event handling configured.gulp-cli
logs events based on the -L
flag level so I set the logger to do logger.debug
which requires the -LLLL
to be used.DEBUG
option to default to true
when undefined. This will still only log when -LLLL
is used but it allows users to disable it through the DEBUG
option by passing in { DEBUG: false }
.For the first bullet, we could listen for the events and write to the console but this will result in duplicate logging when users are using gulp-cli
.
Also, added my name to the contributors list, thanks!
@jackfranklin I reverted the DEBUG changes per your inline comments.
Thank you! @callumacrae does this look good to you? :)
Yep, looks good!
@jackfranklin thanks for merging. Will you publish to npm?
@doowb released as 1.2.3. Thanks :)
This PR is to update dependencies to match some that are used in gulp 4.
gulp-util
fancy-log
for DEBUG loggingfindup-sync
micromatch
(used infindup-sync
andchokidar
forgulp.watch
)Since this is an attempt at consolidating common dependencies, I removed the green coloring around the logging messages. If you'd like to keep that, I can add something for it.