Added .gitignore, Addresses issue#24 and added unit tests

jackfranklin / gulp-load-plugins

Automatically load in gulp plugins

https://github.com/jackfranklin/gulp-load-plugins

MIT License

757 stars 55 forks source link

Added .gitignore, Addresses issue#24 and added unit tests #27

Closed vikikamath closed 10 years ago

vikikamath commented 10 years ago

@Jack thanks for your comment. Please review my pull request for issue#24.

jackfranklin commented 10 years ago

Hey @vikikamath thanks for this. As I mentioned in #24 I'm keen to not add extra features to the library if it's not a common problem people face. I'm going to leave this unmerged for now but if more people ask about it then we can consider merging it in.

vikikamath commented 10 years ago

@jackfranklin :+1: Thanks again for taking your time to review!

sindresorhus commented 10 years ago

:-1: You already got a workaround in #24

jackfranklin commented 10 years ago

Yup, after a bit more thought I'm definitely with @sindresorhus on this one. @vikikamath thank you for taking the time to contribute, but the work around in #24 is what I recommend for this situation.