Closed jackfranklin closed 8 years ago
I'd like to have a go tackling this - what kind of eslint config are you looking for, just recommended rules plus spacing/quotes?
@ryan-codingintrigue amazing! Recommend rules + spacing/quotes would be a great place to start. We can always edit that later in future PRs.
Closed by #97
There is a
.jshintrc
file but it's out of date and it doesn't run on Travis, so I've no doubt the code is breaking the jshint rules!The steps I'd take for this PR would be:
.jshintrc
and get rid of jshint as a dependency frompackage.json
eslint
as a developer dependency (npm install eslint --save-dev
)npm test
so it runseslint
before running the tests. This will ensure that Travis builds fail if ESLint fails.And that's about it! Please feel free to reach out to me with any questions.