search

jackfrost373 / LHCb_Xic_production

Honours programme analysis at MSP for MSP honours students, measuring the production ratio of Xi_c over L_c in the LHCb experiment.
2 stars 4 forks source link

Start CI with Black #70

Closed cpawley closed 2 years ago

cpawley commented 3 years ago

This would run the Black Linter on each push and MR, the output of this would be placed into the console.

At the moment the --diff flag just reports the things Black would reformat - but it doesn't actually do them.

I guess in the first commit it's generally going to be very unhappy. Maybe we should run Black over the whole codebase first and then setup the CI

cpawley commented 3 years ago

Needs some more investigating - should ignore files in e.g. examples, datafiles, archive etc.

cpawley commented 3 years ago

It works finally, but need to discuss how useful this would be - I think if we either apply the recommendations (maybe in another PR) or just let it do so - that would be the best - it depends how much we trust this software to auto-correct our bad formatting without loosing functionality

cpawley commented 3 years ago

I guess we would merge this in --diff mode initially, then make a new PR with which applies all these recommended changes...