Games with non-english characters fail to launch (ie + and ')

jackgllghr / PlayniteEmudeck

A plugin for Playnite to automatically configure Emudeck

11 stars 1 forks source link

Games with non-english characters fail to launch (ie + and ') #5

Open benspray opened 10 months ago

benspray commented 10 months ago

Hi, Just started using this rather than manually configuring everything and its looking good thanks. However one issue I have come across is when a file has a character such as + or ' in the name the argument that gets passed seems to break, the launch window closes too fast for me to catch but I guess its something to do with the emulator argument and how it uses the {imagepath} variable? I'd rather not rename my roms as they are named as per romvault datfile standards ;)

Regards

jackgllghr commented 10 months ago

Hi, thanks for giving it a go! Yeah my guess is it's an escaping issue I've missed, right here at Line 115:

https://github.com/jackgllghr/PlayniteEmudeck/blob/main/Emudeck/EmudeckConfigurator.cs

I'm a bit swamped at the moment but I'll try and get to it soon but happy to accept PRs

jackgllghr commented 9 months ago

This one's tricky, we might need to sanitize the inputs by passing all the arguments into a bash script of our own, as right now we don't have the {ImageDir} to work with.

So it'd go Launch Game > Passes all args to our sanitising script > which passes all args sanitised to emudeck powershell script

Not the most elegant solution but I'll take a look

benspray commented 1 month ago

Hi, any updates :)