jackgugz / pe

0 stars 0 forks source link

Able to add invalid module to the list #10

Open jackgugz opened 2 years ago

jackgugz commented 2 years ago

input: add mod c/GER1111 n/nosuchmod expected: NUS does not have such modules, try again

image.png

actual: image.png

As the app claimed to be for NUS students to manage the Modules, it should be able to reject modules that are not existent in the NUS module system.

nus-pe-bot commented 2 years ago

Team's Response

We validate module codes based on the official guidelines provided by NUS: https://www.nus.edu.sg/registrar/academic-information-policies/graduate/modular-system

Our application is designed for users to keep track of modules that they are enrolled in, and as such, we expect users to add modules that already exist.

Hence, this is not a critical functionality for our target audience.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As the app claimed to be for NUS students to manage the Modules, it should be able to reject modules that are not existent in the NUS module system.

The fact that the application cannot even identify and reject invalid modules validates that it is a critical flaw based on the criteria that Features that are not optimized enough for target users who are students studying NUS modules

For example, in case where a user accidentally enters an invalid module code that is similar to a valid module(e.g. GER1100 vs GER1000), the system should prompt users for correction (and on more advanced development level: correction suggestion), instead of letting it through the system, which may cause inconvenience when the user tries to access the details of the module with the valid module code next time.