search

jackhamel16 / Acoustics

Acoustic integral equation solver
1 stars 0 forks source link

Refactor so that computing triangle area is done less #45

Closed jackhamel16 closed 3 years ago

jackhamel16 commented 3 years ago

computing the triangle area is done for each matrix and vector entry in the fill routines. It should be done once for each triangle and stored in the PulseMesh object.

jackhamel16 commented 3 years ago

during this process remove the integrateTriangle function as it will be useless

jackhamel16 commented 3 years ago

Prior to refactor benchmarking of matrixFill:

BenchmarkTools.Trial: memory estimate: 1009.94 KiB allocs estimate: 9540 minimum time: 337.201 μs (0.00% GC) median time: 456.600 μs (0.00% GC) mean time: 493.235 μs (7.76% GC) maximum time: 6.415 ms (84.47% GC)

BenchmarkTools.Trial: memory estimate: 1009.94 KiB allocs estimate: 9540 minimum time: 349.800 μs (0.00% GC) median time: 434.601 μs (0.00% GC) mean time: 458.324 μs (7.50% GC) maximum time: 2.570 ms (79.91% GC)

BenchmarkTools.Trial: memory estimate: 1009.94 KiB allocs estimate: 9540 minimum time: 351.699 μs (0.00% GC) median time: 377.600 μs (0.00% GC) mean time: 415.983 μs (7.73% GC) maximum time: 2.262 ms (79.37% GC)

jackhamel16 commented 3 years ago

side note: might want to also store triangle centroids. Appears to be called for each matrix entry looking at scalarGreensIntegration function

jackhamel16 commented 3 years ago

Changes made and all tests pass, but needs a once over, benchmarking and cleaning up