Path is a different color from one in minimap

jackhumbert commented 2 years ago

If you notice this, you can run these commands in CET to see which variant it is - I can then build it into the code so the correct color is selected.

Quests:

print(InWorldNavigation.GetInstance().questVariant)

Points of Interest:

print(InWorldNavigation.GetInstance().poiVariant)

It should display one of these - put the variant's name & the color it should be here, and I'll add it and check it off :)

Thortok commented 2 years ago

Will do. I do like the color to match!

Thortok commented 2 years ago

gamedataMappinVariant : SabotageVariant (94) - Gig color (green)

Thortok commented 2 years ago

gamedataMappinVariant : ClientInDistressVariant (16) - Gig color (green)

Thortok commented 2 years ago

gamedataMappinVariant : ThieveryVariant (117) - Gig color (green)

Thortok commented 2 years ago

gamedataMappinVariant : HuntForPsychoVariant (66) - cyberpsycho color (green)

Thortok commented 2 years ago

gamedataMappinVariant : GangWatchVariant (56) - assault in progress, NCPD color (light blue)

Thortok commented 2 years ago

gamedataMappinVariant : HiddenStashVariant (64) - Reported crime, NCPD color (light blue)

Thortok commented 2 years ago

gamedataMappinVariant : Zzz06_NCPDGigVariant (126) - Reported crime followup quest, NCPD gig color (light green, not sure if the exact same as normal gig color)

Thortok commented 2 years ago

gamedataMappinVariant : GangWatchVariant (56) - You must have updated this in the version I just tested, but it's not a color match, looks like you put dark blue (like fast travel point or tarot card) instead of the correct light blue/cyan (like an NCPD location)

Thortok commented 2 years ago

gamedataMappinVariant : OutpostVariant (85) - Suspected Organized Crime Activity - NCPD poi - cyan (gonna call it cyan instead of light blue)

Thortok commented 2 years ago

Another one that got mapped too dark a blue, needs to be cyan

gamedataMappinVariant : HiddenStashVariant (64) - Reported crime, NCPD color (cyan)

Thortok commented 2 years ago

Cyan is the correct color now but it's so bright it still looks wrong.

Thortok commented 2 years ago

Looks better when the scanner is on

Thortok commented 2 years ago

(Hard to take screenshots in HDR, hope those help)

jackhumbert commented 2 years ago

Perfect - thanks! I haven't found a NCPD event to test the cyan yet haha.

Thortok commented 2 years ago

NCPD events are all over the map.... however, the default filter has them off by default. Did you turn them on?

Thortok commented 2 years ago

Make sure the NCPD scanner is turned on....as well as everything else, for testing purposes at least

jackhumbert commented 2 years ago

Ahh - I keep on using my 100% save to test :) they don't respawn do they?

Thortok commented 2 years ago

Nope once you clear them they're gone forever lol

Thortok commented 2 years ago

gamedataMappinVariant : BountyHuntVariant (13) - gig color (Green)

Thortok commented 2 years ago

So this was during a Johnny quest. Johnny quests have an interesting bug. The UI is supposed to change color, but it doesn't always happen. If you die/reload during a Johnny quest that usually triggers it.

With the changed UI, quests are cyan instead of yellow. How to tell if the UI has successfully changed over or not, I don't know.

Anyway, ran the script and it reported this:

gamedataMappinVariant : ExclamationMarkVariant (49)

So make this cyan, maybe? But it won't look right when the UI is still the normal non-Johnny type.

I also don't yet know if this is used outside of Johnny quests in which case it is correctly colored yellow for those. I'm only checking colors that are 'wrong' and not every quest, so...

Thortok commented 2 years ago

gamedataMappinVariant : DefaultQuestVariant (25)

This was during a Johnny quest, so, cyan... Makes me think you'll have to do some Johnny-quest-detection in order to swap color schemes.