search

jackhumbert / pinebook-pro-keyboard-updater

A keyboard/touchpad firmware and updater for the Pinebook Pro
80 stars 11 forks source link

More key combinations #11

Open simson opened 4 years ago

simson commented 4 years ago

Hi, I'm a really happy user of the revised firmware, with super-Arrow ! But now I want more :

I went through your sources really quickly, but i'd like your point of view : is it simple to add such combination ? If so I'll be glad to propose a patch if it'll work. If it's too complex, never mind, it's not that important

jackhumbert commented 4 years ago

Are you using an ISO PBP, or the ANSI? Unfortunately the ISO keyboard's matrix has some limitation on what's possible to press at the same time with some of those keys. I think I'm able to hit all of those on my ANSI, but I have some mods remapped.

simson commented 4 years ago

I'm using an ISO PBP. I don't quite understand your key matrix google sheet. Are those limitations described in this document ?

Le lun. 27 janv. 2020 à 14:25, Jack Humbert notifications@github.com a écrit :

Are you using an ISO PBP, or the ANSI? Unfortunately the ISO keyboard's matrix has some limitation on what's possible to press at the same time with some of those keys. I think I'm able to hit all of those on my ANSI, but I have some mods remapped.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jackhumbert/pinebook-pro-keyboard-updater/issues/11?email_source=notifications&email_token=AAER3OAQZCR2DCCQJIX5423Q73OFXA5CNFSM4KMAUSNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7PFGQ#issuecomment-578744986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER3OB6U5X74Z2HBUACVI3Q73OFXANCNFSM4KMAUSNA .

-- Siméon Marijon

jackhumbert commented 4 years ago

image

This is the matrix configuration for ISO - because Tab shares a column with L Ctrl, and a row with L Shft, it makes it difficult to detect unique keypresses since the keyboard doesn't have any anti-ghosting measures (from what I can tell). You should be able to notice this on keys like WAS (for ISO) as well.

Unfortunately without replacing the keyboard or adding diodes to columns/rows, I don't think preventing this sort of behavior is possible.

One solution for ISO keyboards would be to use the Alt key for combos like this. Overall it looks like measures were taken on the ANSI's matrix to prevent this sort of issue, as the Gui, Ctrl, Alt, and Shift keys are on their own rows:

image

simson commented 4 years ago

Thank you for this clear explanation and all your efforts for the keyboard firmware !

Le lun. 27 janv. 2020 à 15:42, Jack Humbert notifications@github.com a écrit :

[image: image] https://user-images.githubusercontent.com/141431/73182941-f4fbff00-40e7-11ea-81e0-6102de762529.png

This is the matrix configuration for ISO - because Tab shares a column with L Ctrl, and a row with L Shft, it makes it difficult to detect unique keypresses since the keyboard doesn't have any anti-ghosting measures (from what I can tell). You should be able to notice this on keys like WAS (for ISO) as well.

Unfortunately without replacing the keyboard or adding diodes to columns/rows, I don't think preventing this sort of behavior is possible.

One solution for ISO keyboards would be to use the Alt key for combos like this. Overall it looks like measures were taken on the ANSI's matrix to prevent this sort of issue, as the Gui, Ctrl, Alt, and Shift keys are on their own rows:

[image: image] https://user-images.githubusercontent.com/141431/73183765-5b355180-40e9-11ea-87e2-1942b3e4b03b.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jackhumbert/pinebook-pro-keyboard-updater/issues/11?email_source=notifications&email_token=AAER3OCKMKTQNYVMAWANX2DQ73XGRA5CNFSM4KMAUSNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7X3GI#issuecomment-578780569, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER3OFZKYTH572JJ77S2N3Q73XGRANCNFSM4KMAUSNA .

-- Siméon Marijon