search

jackhumbert / pinebook-pro-keyboard-updater

A keyboard/touchpad firmware and updater for the Pinebook Pro
78 stars 11 forks source link

Improve the language and consistency of the printed messages #36

Closed dragan-simic closed 2 years ago

dragan-simic commented 3 years ago

This pull request contains various improvements to the messages printed during the update process. Both the language and the consistency of the logged messages are improved. The README.md file is updated as well, to reflect the changes in the code.

I've also tested the code by running all three update steps on an ISO PineBook Pro.

dragan-simic commented 2 years ago

Just checking, why wasn't this merged?

jackhumbert commented 2 years ago

This repo is a fork of the original, and I didn't write/modify any of those files (and therefore can't evaluate these changes). You may want to make the pull request on the original repo: https://github.com/ayufan-rock64/pinebook-pro-keyboard-updater

dragan-simic commented 2 years ago

Thank you for the update, I'll create a pull request on the original GitHub repository.